Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Unwrap text on topbar sort options #1981

Conversation

chth0n1x
Copy link
Contributor

@chth0n1x chth0n1x commented Aug 30, 2023

  • Ticket: TBD
  • Feature flag: n/a

Purpose

The purpose of these changes was to remove wrapping text in the topbar sort dropdown option selection.

Summary of Changes

  • margin for sort dropdown paragraph elements was removed
  • a local class selector for sort dropdown options was added
  • padding was added to sort dropdown options and the bottom margin removed
  • white-space:no-wrap was added to the sort dropdown local class selector

Screenshot(s)

Search OSF

Figure 1: Corrected sort dropdown text wrap on desktop view

image

Figure 2: Corrected dropdown text on mobile/tablet

Side Effects

There should be no formal side-effects, but this may displace the topbar UI if not properly implemented.

QA Notes

-Do the elements properly display? Is there any text wrapping taking place on any of the options?
-A negative margin can correct the placement of the right dropdown arrow but this is not recommended practice; is there no excessive overlap currently with the button?

@chth0n1x chth0n1x changed the title [Hotfix] Unwrap text on topbar sort option [Hotfix] Unwrap text on topbar sort options Aug 30, 2023

p {
margin: 0 0 0 2px;
margin: 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of the dropdown arrow can be further improved with a negative margin, but this was not recommended in a previous PR. If preferred however for UI, I can add it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6029858003

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.83%

Totals Coverage Status
Change from base Build 6014426417: 0.0%
Covered Lines: 6017
Relevant Lines: 8264

💛 - Coveralls

@adlius
Copy link
Contributor

adlius commented Aug 31, 2023

Screenshot from 2023-08-31 10-58-34
The sort dropdown looks a bit odd in smaller screen sizes

@adlius adlius closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants