Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See example hot fix #2070

Merged

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented Nov 30, 2023

Found during regression on live servers

  • Ticket: []
  • Feature flag: n/a

Purpose

The "see example" button was attempting to go to a /content/ route that was not ported from OSP.

Summary of Changes

Removed the "content" prefix

Screenshot(s)

N/A

Side Effects

As long as the "example" is set admin, it will go to that preprint example. if the example is not set then it will go to the default OSF example.

QA Notes

Fill in the admin and click the button.

adlius and others added 3 commits November 30, 2023 12:03
Preprint detail and landing page rewrite
Hotfix favicon for preprint discover page
@bp-cos bp-cos requested review from adlius and futa-ikeda November 30, 2023 20:18
@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7051952948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.25%

Totals Coverage Status
Change from base Build 7051672128: 0.0%
Covered Lines: 6065
Relevant Lines: 8506

💛 - Coveralls

@adlius adlius merged commit 2d36d41 into CenterForOpenScience:hotfix/23.15.2 Nov 30, 2023
9 checks passed
bp-cos added a commit to bp-cos/ember-osf-web that referenced this pull request Jan 31, 2024
* Fixed the route for the see example bad link

* Moved to an "in-app" transition and included a new preprint in mirage

---------

Co-authored-by: Yuhuai Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants