Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5009] Stop loading node in route model hook #2077

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[ENG-5009] Stop loading node in route model hook #2077

merged 1 commit into from
Dec 7, 2023

Conversation

adlius
Copy link
Contributor

@adlius adlius commented Dec 6, 2023

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@adlius adlius changed the title Stop loading node in route model hook [ENG-5009] Stop loading node in route model hook Dec 6, 2023
bp-cos
bp-cos approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@bp-cos bp-cos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that it worked both ways.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7118484506

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 69.244%
Totals Coverage Status
Change from base Build 7089267861: 0.005%
Covered Lines: 6065
Relevant Lines: 8507
💛 - Coveralls

@adlius adlius merged commit 7ce1e37 into CenterForOpenScience:hotfix/23.15.2 Dec 7, 2023
9 checks passed
adlius added a commit that referenced this pull request Dec 12, 2023
@adlius
stop loading node in route model hook (#2077)
374cba3
bp-cos pushed a commit to bp-cos/ember-osf-web that referenced this pull request Jan 31, 2024
@adlius @bp-cos
stop loading node in route model hook (CenterForOpenScience#2077)
475ca37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bp-cos bp-cos bp-cos approved these changes

@futa-ikeda futa-ikeda futa-ikeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adlius @coveralls @futa-ikeda @bp-cos