[ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) #2321

bp-cos · 2024-09-10T20:23:34Z

Ticket: ENG-5919
Feature flag: n/a

Purpose

Request to merge the feature/preprints-affiliations branch into develop for release.

Summary of Changes

Merge all the feature work into the develop branch

…institutions

…dded a test

…tion

…edit

…utions

* fix preprint resubmission workflow * Update test for review-action model to reflect target relationship change * delete review-action relationship from child classes * ENG-6008: Add My Preprints route and page template * setup mirage route and view * change defaultSortKey attribute * Bump version no. Add CHANGELOG * create preprint card * fix date format * formatting changes * remove unnecessary controller and old logic * Add tests * remove unused classes and services * Moved changes to preprints-paginated-list branch * remove redundant pagination component * add usePlaceholders property --------- Co-authored-by: Uditi Mehta <[email protected]> Co-authored-by: Uditi Mehta <[email protected]> Co-authored-by: Yuhuai Liu <[email protected]> Co-authored-by: Uditi Mehta <[email protected]>

# Conflicts: # app/models/preprint.ts # mirage/serializers/preprint.ts

…ions Try to resolve merge conflicts

coveralls · 2024-09-11T14:03:41Z

Pull Request Test Coverage Report for Build 10907866856

Details

240 of 280 (85.71%) changed or added relevant lines in 11 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.6%) to 63.701%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/preprints/-components/submit/author-assertions/public-data/component.ts	0	2	0.0%
app/preprints/-components/submit/author-assertions/public-preregistration/component.ts	0	2	0.0%
app/preprints/-components/submit/metadata/component.ts	0	2	0.0%
app/preprints/-components/submit/author-assertions/component.ts	0	3	0.0%
app/preprints/edit/route.ts	0	3	0.0%
app/preprints/-components/preprint-institutions/institution-manager/component-test.ts	118	122	96.72%
app/preprints/-components/preprint-institutions/institution-manager/component.ts	27	31	87.1%
app/preprints/-components/submit/preprint-state-machine/component.ts	0	20	0.0%

Files with Coverage Reduction	New Missed Lines	%
app/preprints/edit/route.ts	1	0.0%

Totals
Change from base Build 10855743272:	0.6%
Covered Lines:	6474
Relevant Lines:	9795

💛 - Coveralls

brianjgeiger

The most minor of changes to some tests, and it looks like from Percy there's changes to the developer apps page that was unintended, but otherwise looks good.

Update: It looks like the developer app problem came from somewhere else. It would be awesome if it could be fixed quickly here, but otherwise just make a ticket and we can fix it in B&I.

app/preprints/-components/preprint-institutions/institution-manager/component-test.ts

…s-affiliations

brianjgeiger · 2024-09-17T13:35:01Z

Looks like there were some unintended changes to the developer apps page that will need to be corrected.

cslzchen · 2024-09-17T16:29:30Z

It seems the new changes come from last week's hotfix.

Maybe taking a look with @futa-ikeda to see if they can be dismissed/manually approved.

cslzchen · 2024-09-17T16:38:54Z

Oh, it's not from the hotfix, it's our develop branch has an issue

And the history showed that last FE release also had 3 percy issues and two recent merge into develop increase that to 14 and this PR increases that change to 17.

[ENG-5919] Fixed some typos

bp-cos and others added 30 commits July 24, 2024 11:13

Added a new relationship for the affiliated institutions

5202389

updates to the serializers

2961832

Updates to the component and initial tests

8dec4a1

Added a trait

02d061c

Added more tests and updates

1ea3279

Added more tests to the scenario

513b301

Updates to persist affiliated institutions

179c4be

Fixed the tests

5a58e8f

Added logic for mobile and to only display if there are affilitiated …

05ee0f4

…institutions

added functionality that all preprints are selected on create mode. A…

40ace97

…dded a test

Added a description for the institutional affiliations

b70e96f

Added a label for accessibility

81f7846

add affiliated institution details to preprints

da35c74

add affiliated institution links and logs to the preprint detail page.

ff96e4a

improve logo size and shape

29ed5df

update css to new techniques

9dd3886

make links open in new tab

7e29e06

restrict image sizes

243dd34

fix single quotes

2894bc6

add tests for preprint affiliations and clean up css

b197b10

Added some test fixes

34ecc44

Add code for institutions preprint affiliations widget on reviews sec…

5ec6496

…tion

fix component to add title to css and conditional template

8616932

refactor to reviewsPage and fix linting error and tests

8dbde95

make Institutional affiliations label disappear if no institutions

ffe35cc

add hover-text and simplify css

88922dd

Updates to make affiliated institutions read-only and fixed a bug on …

b4ea1dd

…edit

Fixed a test

5eecaca

Updated the logic on selecting and persisting of affiliated institutions

f582cc4

Fixed the tests

03f6291

bp-cos and others added 12 commits August 22, 2024 13:32

Added a link test

cc924ef

Fixed a missed translation on a cancel button for mobile

99fafbd

Fixed the initial issue with read/write users and updated the tests

a4dd64c

Added another test

0c5e5d7

Updated logic and tests to allow admin and write users access

4a98031

Fixed a test with new mirage settings

55e8597

Added logic to fix a bug on preprint edit flow with affiliated instit…

7227b3b

…utions

allow write contribs to add affiliations

1af9112

improve permission handling

5a6de56

Updates to mirage to handle adding and removing affiliated institutions

a195c22

reintroduce isAdmin

a7f75f7

bp-cos requested review from brianjgeiger and futa-ikeda September 10, 2024 20:23

brianjgeiger and others added 3 commits September 11, 2024 09:16

Merge branch 'develop' into upstream/preprints-affiliations

cad9361

# Conflicts: # app/models/preprint.ts # mirage/serializers/preprint.ts

Don't double-add relationships

3cbd25a

Merge pull request #2323 from brianjgeiger/feature/preprints-affiliat…

b55d735

…ions Try to resolve merge conflicts

brianjgeiger requested changes Sep 11, 2024

View reviewed changes

bp-cos and others added 2 commits September 12, 2024 10:18

Removed the cancel button

9a3a11b

Merge remote-tracking branch 'upstream/develop' into feature/preprint…

b813257

…s-affiliations

cslzchen force-pushed the feature/preprints-affiliations branch from 32d1042 to b813257 Compare September 16, 2024 20:18

Fixed some typos

262e671

Merge pull request #2332 from bp-cos/pr-update/eng-5919

55f9dec

[ENG-5919] Fixed some typos

brianjgeiger approved these changes Sep 17, 2024

View reviewed changes

cslzchen changed the title ~~[ENG-5919] Request to merge the feature/preprints-affiliations branch into develop for release.~~ [ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) Sep 18, 2024

cslzchen merged commit f7bcde1 into develop Sep 18, 2024
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) #2321

[ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) #2321

bp-cos commented Sep 10, 2024 •

edited by jira bot

Loading

coveralls commented Sep 11, 2024 •

edited

Loading

brianjgeiger left a comment •

edited

Loading

brianjgeiger commented Sep 17, 2024

cslzchen commented Sep 17, 2024 •

edited

Loading

cslzchen commented Sep 17, 2024

[ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) #2321

[ENG-5028] [ENG-5919] Preprints Affiliation Project PR (FE) #2321

Conversation

bp-cos commented Sep 10, 2024 • edited by jira bot Loading

Purpose

Summary of Changes

coveralls commented Sep 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10907866856

Details

💛 - Coveralls

brianjgeiger left a comment • edited Loading

Choose a reason for hiding this comment

brianjgeiger commented Sep 17, 2024

cslzchen commented Sep 17, 2024 • edited Loading

cslzchen commented Sep 17, 2024

bp-cos commented Sep 10, 2024 •

edited by jira bot

Loading

coveralls commented Sep 11, 2024 •

edited

Loading

brianjgeiger left a comment •

edited

Loading

cslzchen commented Sep 17, 2024 •

edited

Loading