[ENG-6122] Added new attributes to the mirage factories #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
approved these changes
Sep 20, 2024
Comment on lines
25
to
26
| storageByteCount() { | ||
| return faker.random.number({ min: 100, max: 1000 }); |
There was a problem hiding this comment.
Nit: Could be worthwhile to bump the max on this one a little higher
mirage/factories/institution.ts
Outdated
Comment on lines
52
to
63
| summaryMetrics.update({ | ||
| publicProjectCount, | ||
| privateProjectCount, | ||
| userCount, | ||
| publicRegistrationCount: 1250, | ||
| preprintCount: 11250, | ||
| embargoedRegistrationCount: 456, | ||
| storageByteCount: 47382032, | ||
| publicFileCount: 87, | ||
| monthlyLoggedInUserCount: 24563, | ||
| monthlyActiveUserCount:456, | ||
| }); |
There was a problem hiding this comment.
It seems like the logic that was here before this PR was trying to be smart and infer publicProjectCount, privateProjectCount and userCount from the 15 institution-users created on line 36 to make the data look a bit more "realistic". While I think that was likely a good idea when we showed the user numbers and summary numbers on the same page before, I don't think this entire summaryMetrics.update is necessary anymore.
Nit: Would you mind removing this update block and lines 42-48 (const userCount through userMetrics.forEach)?
bp-cos
merged commit ac605ac
into
CenterForOpenScience:feature/insti-dash-improv
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added new attributes to the mirage factories
Summary of Changes
Added attributes to the institution-summary-metric and instution mirage files.