Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6183] Project list filtering #2345

Merged
merged 5 commits into from
Oct 7, 2024
Merged

[ENG-6183] Project list filtering #2345

merged 5 commits into from
Oct 7, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Sep 27, 2024 •
edited by jira bot
Loading

Purpose

  • Add filtering capability to Institutional Dashboard's Project page

Summary of Changes

  • Update mirage's index-value-search view to handle filterable values
  • Add filtering logic to the page and show active filters on right-sidebar
    • Update OsfLayout to be able to manually set the left and right sidebar behavior regardless of device size
  • Add total results count to object-list component

Screenshot(s)

  • desktop
    image
    image

  • mobile
    image
    image

Side Effects

QA Notes

brianjgeiger
brianjgeiger approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thank you for fixing the spacing on the translation strings.

@futa-ikeda futa-ikeda merged commit a9056a2 into CenterForOpenScience:feature/insti-dash-improv Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

@aaxelb aaxelb Awaiting requested review from aaxelb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger