Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6184] Allow sorting for project list #2348

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[ENG-6184] Allow sorting for project list #2348

merged 2 commits into from
Oct 9, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 9, 2024 •
edited by jira bot
Loading

Purpose

  • Allow sorting for project table

Summary of Changes

  • Add new optional sortKey to project column object
    • Show sort arrow if the sortKey is present on the column
  • Styling updates
  • Add pagination links to object list

Screenshot(s)

  • Desktop
    image
  • Mobile
    image

Side Effects

QA Notes

brianjgeiger
brianjgeiger approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@futa-ikeda futa-ikeda merged commit 3259cfd into CenterForOpenScience:feature/insti-dash-improv Oct 9, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the insti-project-sort branch October 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger