Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6346] Update logic to set initial folder id in file manager #2356

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 15, 2024

Purpose

  • Address a bug where the root folder picker doesn't show the correct folder content when widget loads (shows root folder's parent, not root folder's contents). See video in ticket for better description

Summary of Changes

  • Update types
  • Set currentFolder to be the explicit Id of the starting folder
  • Always show Home option in breadcrumbs

Screenshot(s)

  • Prevents this bug where "All Files" is apparently the current folder content that you are viewing, and while also only showing the "All Files item"
    image
  • Should look like this if "All Files" is the selected root folder upon loading this page:
    image
  • Should look like this if no root folder is selected
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda marked this pull request as draft October 17, 2024 01:36
@futa-ikeda futa-ikeda marked this pull request as ready for review October 18, 2024 18:38
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

@@ -351,6 +352,7 @@ addons:
configure:
heading: 'Configure {providerName}'
display-name: 'Display name'
go-to-root: 'Go to root'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'Go to home' or 'Go to home folder' to match up the aria label with the UI?

@futa-ikeda futa-ikeda merged commit 20d8c18 into CenterForOpenScience:feature/addon-services Oct 21, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the root-folder-picker-bug branch October 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants