Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No ticket] Update language and counts on summary page #2381

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[No ticket] Update language and counts on summary page #2381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3e82e
Update language and counts on summary page
futa-ikeda Nov 6, 2024
a62b92d
Update tests
futa-ikeda Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/institutions/dashboard/-components/total-count-kpi-wrapper/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ export default class TotalCountKpiWrapperComponent extends Component<TotalCountK
return summaryMetrics.privateProjectCount + summaryMetrics.publicProjectCount;
}

private calculateRegistrations(summaryMetrics: InstitutionSummaryMetricModel): number {
return summaryMetrics.embargoedRegistrationCount + summaryMetrics.publicRegistrationCount;
}

@task
@waitFor
private async loadData(): Promise<void> {
Expand Down Expand Up @@ -70,7 +74,7 @@ export default class TotalCountKpiWrapperComponent extends Component<TotalCountK
},
{
title: this.intl.t('institutions.dashboard.kpi-panel.registrations'),
total: metrics.summaryMetrics.publicRegistrationCount,
total: this.calculateRegistrations(metrics.summaryMetrics),
icon: 'archive',
},
{
Expand Down
8 changes: 4 additions & 4 deletions translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ institutions:
kpi-panel:
users: 'Total Users'
projects: 'OSF Public and Private Projects'
registrations: 'OSF Registrations'
registrations: 'OSF Public and Embargoed Registrations'
preprints: 'OSF Preprints'
storage: 'Total Storage in {unit}'
file-count: 'Total Public File Count'
Expand All @@ -859,9 +859,9 @@ institutions:
total-osf-objects:
title: 'Total OSF Objects'
preprints: 'Preprints'
licenses: 'Licenses'
add-ons: 'Add-ons'
storage-regions: 'Storage Regions'
licenses: 'Top 10 Licenses'
add-ons: 'Top 10 Add-ons'
storage-regions: 'Top Storage Regions'
public-vs-private-data-storage:
title: 'Public vs Private Data Storage'
public: 'Public Data Storage'
Expand Down
Loading