Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6419] Update SHARE getters #2384

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[ENG-6419] Update SHARE getters #2384

merged 2 commits into from
Nov 7, 2024
+49 −50

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 7, 2024 •
edited by jira bot
Loading

Purpose

  • Make use of new utility functions to make it easier to ready/write property getters from SHARE

Summary of Changes

  • Update institutional Dashboard controllers that had old getters to use new utility functions
  • Update search-result.ts to use new utility functions
    • Remove an old utility method that is now made redundant

Screenshot(s)

  • NA

Side Effects

QA Notes

@futa-ikeda futa-ikeda merged commit 0efac04 into CenterForOpenScience:feature/insti-dash-improv Nov 7, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the update-getters branch November 7, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger