Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6991][ENG-6997][ENG-7001][ENG-7002][IAC] Simple FE Fixes #2486

Merged

Conversation

Johnetordoff
Copy link
Collaborator

@Johnetordoff Johnetordoff commented Jan 21, 2025

  • Ticket: [https://openscience.atlassian.net/browse/ENG-6991]
  • Feature flag: n/a

Purpose

Do the IAC clean-up fixes

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor grammar issue. Rest seems good

translations/en-us.yml Outdated Show resolved Hide resolved
@Johnetordoff Johnetordoff marked this pull request as ready for review January 22, 2025 18:41
futa-ikeda
futa-ikeda previously approved these changes Jan 22, 2025
@Johnetordoff Johnetordoff changed the base branch from feature/institutional-access to develop January 23, 2025 20:45
@Johnetordoff Johnetordoff dismissed futa-ikeda’s stale review January 23, 2025 20:45

The base branch was changed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12937816363

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 64.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/institutions/dashboard/-components/object-list/component.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
app/adapters/node-request.ts 1 33.33%
Totals Coverage Status
Change from base Build 12895413643: -0.004%
Covered Lines: 6979
Relevant Lines: 10403

💛 - Coveralls

@Johnetordoff Johnetordoff changed the base branch from develop to feature/b-and-i-25-01 January 29, 2025 15:43
@Johnetordoff Johnetordoff merged commit 79100e8 into CenterForOpenScience:feature/b-and-i-25-01 Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants