Skip to content

Commit

Permalink
add monthly active stat to users table
Browse files Browse the repository at this point in the history
  • Loading branch information
John Tordoff committed Oct 17, 2024
1 parent 09fb099 commit 1c24a5c
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 0 deletions.
1 change: 1 addition & 0 deletions api/institutions/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ class Meta:
department = ser.CharField(read_only=True, source='department_name')
orcid_id = ser.CharField(read_only=True)
month_last_login = YearmonthField(read_only=True)
month_last_active = YearmonthField(read_only=True)
account_creation_date = YearmonthField(read_only=True)

public_projects = ser.IntegerField(read_only=True, source='public_project_count')
Expand Down
1 change: 1 addition & 0 deletions api/institutions/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,7 @@ class _NewInstitutionUserMetricsList(InstitutionMixin, ElasticsearchListView):
'user_name',
'department',
'month_last_login',
'month_last_active',
'account_creation_date',
'public_projects',
'private_projects',
Expand Down
18 changes: 18 additions & 0 deletions osf/metrics/reporters/institutional_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def __post_init__(self):
if self.user.date_last_login is not None
else None
),
month_last_active=self._get_last_active(),
account_creation_date=YearMonth.from_date(self.user.created),
orcid_id=self.user.get_verified_external_id('ORCID', verified_only=True),
public_project_count=self._public_project_queryset().count(),
Expand Down Expand Up @@ -140,3 +141,20 @@ def _storage_byte_count(self):
purged__isnull=True,
basefilenode__in=self._public_osfstorage_file_queryset(),
).aggregate(storage_bytes=Sum('size', default=0))['storage_bytes']

def _get_last_active(self):
end_date = self.yearmonth.next_month()

node_logs = self.user.logs.filter(created__lt=end_date).order_by('-created')
preprint_logs = self.user.preprint_logs.filter(created__lt=end_date).order_by('-created')

latest_node_log_date = node_logs.first().created if node_logs.exists() else None
latest_preprint_log_date = preprint_logs.first().created if preprint_logs.exists() else None
dates = [date for date in [latest_node_log_date, latest_preprint_log_date] if date is not None]

latest_activity_date = max(dates, default=None)

if latest_activity_date:
return YearMonth.from_date(latest_activity_date)
else:
return None
1 change: 1 addition & 0 deletions osf/metrics/reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ class InstitutionalUserReport(MonthlyReport):
user_name = metrics.Keyword()
department_name = metrics.Keyword()
month_last_login = YearmonthField()
month_last_active = YearmonthField()
account_creation_date = YearmonthField()
orcid_id = metrics.Keyword()
# counts:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ def _assert_report_matches_setup(self, report: InstitutionalUserReport, setup: _
self.assertEqual(report.user_name, setup.user.fullname)
self.assertEqual(report.department_name, setup.department_name)
self.assertEqual(report.month_last_login, YearMonth.from_date(setup.user.date_last_login))
if setup.user.month_last_active:
self.assertEqual(report.month_last_active, YearMonth.from_date(setup.user.month_last_active))
else:
self.assertEqual(report.month_last_active, setup.user.month_last_active)

self.assertEqual(report.account_creation_date, YearMonth.from_date(setup.user.created))
self.assertEqual(report.orcid_id, setup.orcid_id)
# counts (NOTE: report.public_file_count and report.storage_byte_count tested separately)
Expand Down Expand Up @@ -159,6 +164,8 @@ def __post_init__(self):
),
)
self._add_affiliations(self._generate_counted_objects())
recent_log = self.user.logs.order_by('-created').first()
self.user.month_last_active = getattr(recent_log, 'created', None)

def affiliate_user(self):
self.user.add_or_update_affiliated_institution(
Expand Down

0 comments on commit 1c24a5c

Please sign in to comment.