fix: duplicate reports when run for past years

CenterForOpenScience · Oct 18, 2024 · a93eb05 · a93eb05
1 parent 09fb099
commit a93eb05
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/osf/metrics/reports.py b/osf/metrics/reports.py
@@ -29,6 +29,11 @@ def __init_subclass__(cls, **kwargs):
         super().__init_subclass__(**kwargs)
         assert 'report_date' in cls.UNIQUE_TOGETHER_FIELDS, f'DailyReport subclasses must have "report_date" in UNIQUE_TOGETHER_FIELDS (on {cls.__qualname__}, got {cls.UNIQUE_TOGETHER_FIELDS})'
 
+    def save(self, *args, **kwargs):
+        if self.timestamp is None:
+            self.timestamp = self.report_date
+        super().save(*args, **kwargs)
+
     class Meta:
         abstract = True
         dynamic = metrics.MetaField('strict')
@@ -101,6 +106,12 @@ def __init_subclass__(cls, **kwargs):
         super().__init_subclass__(**kwargs)
         assert 'report_yearmonth' in cls.UNIQUE_TOGETHER_FIELDS, f'MonthlyReport subclasses must have "report_yearmonth" in UNIQUE_TOGETHER_FIELDS (on {cls.__qualname__}, got {cls.UNIQUE_TOGETHER_FIELDS})'
 
+    def save(self, *args, **kwargs):
+        if self.timestamp is None:
+            self.timestamp = self.report_yearmonth.target_month()
+        super().save(*args, **kwargs)
+
+
 
 @receiver(metrics_pre_save)
 def set_report_id(sender, instance, **kwargs):