add view name to file download

CenterForOpenScience · Oct 25, 2024 · c1dac13 · c1dac13
1 parent 4472a44
commit c1dac13
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/api/base/settings/defaults.py b/api/base/settings/defaults.py
@@ -359,7 +359,7 @@
 
 MAX_SIZE_OF_ES_QUERY = 10000
 DEFAULT_ES_NULL_VALUE = 'N/A'
-REPORT_FILENAME_FORMAT = 'osf_report_{date_created}.{format_type}'
+REPORT_FILENAME_FORMAT = '{view_name}_{date_created}.{format_type}'
 
 CI_ENV = False
 

diff --git a/api/metrics/renderers.py b/api/metrics/renderers.py
@@ -65,6 +65,7 @@ def get_filename(self, renderer_context: dict, format_type: str) -> str:
         if renderer_context and 'view' in renderer_context:
             current_date = datetime.datetime.now().strftime('%Y-%m')
             return REPORT_FILENAME_FORMAT.format(
+                view_name=renderer_context['view'].view_name,
                 date_created=current_date,
                 format_type=format_type,
             )

diff --git a/api_tests/institutions/views/test_institution_user_metric_list.py b/api_tests/institutions/views/test_institution_user_metric_list.py
@@ -436,6 +436,7 @@ def test_get_report_formats_csv_tsv(self, app, url, institutional_admin, institu
 
         current_date = datetime.datetime.now().strftime('%Y-%m')
         expected_filename = REPORT_FILENAME_FORMAT.format(
+            view_name='institution-user-metrics',
             date_created=current_date,
             format_type=format_type
         )
@@ -516,6 +517,7 @@ def test_get_report_format_json(self, app, url, institutional_admin, institution
 
         current_date = datetime.datetime.now().strftime('%Y-%m')
         expected_filename = REPORT_FILENAME_FORMAT.format(
+            view_name='institution-user-metrics',
             date_created=current_date,
             format_type='json'
         )
@@ -601,6 +603,7 @@ def test_csv_tsv_ignores_pagination(self, app, url, institutional_admin, institu
 
         current_date = datetime.datetime.now().strftime('%Y-%m')
         expected_filename = REPORT_FILENAME_FORMAT.format(
+            view_name='institution-user-metrics',
             date_created=current_date,
             format_type=format_type
         )