add user_name field

CenterForOpenScience · Sep 5, 2024 · fddcf78 · fddcf78
1 parent 7fdc6ea
commit fddcf78
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/osf/metrics/reporters/institutional_users.py b/osf/metrics/reporters/institutional_users.py
@@ -40,6 +40,7 @@ def __post_init__(self):
             report_yearmonth=self.yearmonth,
             institution_id=self.institution._id,
             user_id=self.user._id,
+            user_name=self.user.fullname,
             department_name=(_affiliation.sso_department or None),
             month_last_login=YearMonth.from_date(self.user.date_last_login),
             account_creation_date=YearMonth.from_date(self.user.created),

diff --git a/osf/metrics/reports.py b/osf/metrics/reports.py
@@ -232,7 +232,8 @@ class InstitutionalUserReport(MonthlyReport):
     institution_id = metrics.Keyword()
     # user info:
     user_id = metrics.Keyword()
-    department_name = metrics.Keyword()
+    user_name = metrics.Text()
+    department_name = metrics.Text()
     month_last_login = YearmonthField()
     account_creation_date = YearmonthField()
     orcid_id = metrics.Keyword()

diff --git a/osf_tests/metrics/reporters/test_institutional_users_reporter.py b/osf_tests/metrics/reporters/test_institutional_users_reporter.py
@@ -54,6 +54,7 @@ def _assert_report_matches_setup(self, report: InstitutionalUserReport, setup: _
         self.assertEqual(report.institution_id, setup.institution._id)
         # user info:
         self.assertEqual(report.user_id, setup.user._id)
+        self.assertEqual(report.user_name, setup.user.fullname)
         self.assertEqual(report.department_name, setup.department_name)
         self.assertEqual(report.month_last_login, YearMonth.from_date(setup.user.date_last_login))
         self.assertEqual(report.account_creation_date, YearMonth.from_date(setup.user.created))