-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Institutional Dashboard User Metrics Endpoint #10712
Closed
Johnetordoff
wants to merge
11
commits into
CenterForOpenScience:develop
from
Johnetordoff:institutional-dashboard
Closed
[WIP] Institutional Dashboard User Metrics Endpoint #10712
Johnetordoff
wants to merge
11
commits into
CenterForOpenScience:develop
from
Johnetordoff:institutional-dashboard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rOpenScience/osf.io into institutional-dashboard * 'institutional-dashboard' of https://github.com/CenterForOpenScience/osf.io: WIP # Conflicts: # api/institutions/views.py # api_tests/institutions/views/test_institution_dashboard_user.py
Johnetordoff
force-pushed
the
institutional-dashboard
branch
from
August 22, 2024 12:12
b5cdd68
to
898c349
Compare
…rOpenScience/osf.io into institutional-dashboard * 'institutional-dashboard' of https://github.com/CenterForOpenScience/osf.io: WIP # Conflicts: # api/institutions/views.py # api_tests/institutions/views/test_institution_dashboard_user.py
Johnetordoff
force-pushed
the
institutional-dashboard
branch
from
August 22, 2024 12:16
898c349
to
774ef34
Compare
Johnetordoff
commented
Aug 22, 2024
@@ -6,12 +6,14 @@ class MetricsCSVRenderer(CSVRenderer): | |||
CSVRenderer with updated render method to export `data` dictionary of API Response to CSV | |||
""" | |||
|
|||
def render(self, data, media_type=None, renderer_context={}, writer_opts=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having problems with this being a mutable argument.
Johnetordoff
force-pushed
the
institutional-dashboard
branch
2 times, most recently
from
August 22, 2024 12:34
c93701c
to
a74e06b
Compare
into institutional-dashboard * 'develop' of https://github.com/CenterForOpenScience/osf.io: (41 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ... # Conflicts: # api/users/serializers.py # conftest.py
Johnetordoff
force-pushed
the
institutional-dashboard
branch
from
August 22, 2024 13:04
a74e06b
to
4675384
Compare
Johnetordoff
force-pushed
the
institutional-dashboard
branch
8 times, most recently
from
August 22, 2024 17:58
456b66d
to
5df26a5
Compare
Johnetordoff
changed the title
[WIP] Institutional Dashboard POC BE
[WIP] Institutional Dashboard User Metrics Endpoint
Aug 22, 2024
Johnetordoff
force-pushed
the
institutional-dashboard
branch
from
August 22, 2024 18:03
5df26a5
to
85d0e59
Compare
Johnetordoff
force-pushed
the
institutional-dashboard
branch
from
August 22, 2024 18:38
85d0e59
to
1b98d5d
Compare
…rOpenScience/osf.io into institutional-dashboard * 'institutional-dashboard' of https://github.com/CenterForOpenScience/osf.io: # Conflicts: # api/institutions/views.py # api_tests/institutions/views/test_institution_dashboard_user.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To show the viability of certain BE features of the institutional dashboard
Changes
InstitutionDashboardUserList
that will display user info for the dashboardQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket