[ENG-6012] Filter out deleted preprints for preprint drafts lists #10731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
filter-deleted-preprint-drafts
branch
from
63820ff
to
fb8aeb6
Compare
Johnetordoff
force-pushed
the
filter-deleted-preprint-drafts
branch
from
fb8aeb6
to
7441de0
Compare
brianjgeiger
approved these changes
Aug 30, 2024
brianjgeiger
merged commit 72f5275
into
CenterForOpenScience:feature/b-and-i-24-14
6 checks passed
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Sep 17, 2024
into feature/insti-dash-improv-merge * 'develop' of https://github.com/CenterForOpenScience/osf.io: (42 commits) Fix task name for clear_expired_sessions in celery schedule Update CHANGELOG, bump version Revert "Add logging to post-commit handlers" filter out deleted preprint drafts (CenterForOpenScience#10731) add debugging remove debugging remove debugging Revert "Add logging to post-commit handlers" Update commit to warning level Update commit to warning level Update commit to warning level Update commit to warning level Add logging to post-commit handlers Add logging to post-commit handlers revert resend confirmation to synchronous version add preprint draft relationship to user add PreprintDraftSerializer remove command file Move notification deletion to a dedicated view and remove obsolete duplicate notification handling logic. move duplicate notification handling to node detail page ... # Conflicts: # api_tests/institutions/views/test_institution_user_metric_list.py # osf_tests/management_commands/test_reindex_es6.py
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Sep 18, 2024
…ForOpenScience/osf.io into new-summary-reports * 'feature/insti-dash-improv' of https://github.com/CenterForOpenScience/osf.io: (43 commits) fix: usable waffle-flag admin Fix task name for clear_expired_sessions in celery schedule Update CHANGELOG, bump version Revert "Add logging to post-commit handlers" filter out deleted preprint drafts (CenterForOpenScience#10731) add debugging remove debugging remove debugging Revert "Add logging to post-commit handlers" Update commit to warning level Update commit to warning level Update commit to warning level Update commit to warning level Add logging to post-commit handlers Add logging to post-commit handlers revert resend confirmation to synchronous version add preprint draft relationship to user add PreprintDraftSerializer remove command file Move notification deletion to a dedicated view and remove obsolete duplicate notification handling logic. ...
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Sep 18, 2024
…ForOpenScience/osf.io into new-summary-reports * 'feature/insti-dash-improv' of https://github.com/CenterForOpenScience/osf.io: (43 commits) fix: usable waffle-flag admin Fix task name for clear_expired_sessions in celery schedule Update CHANGELOG, bump version Revert "Add logging to post-commit handlers" filter out deleted preprint drafts (CenterForOpenScience#10731) add debugging remove debugging remove debugging Revert "Add logging to post-commit handlers" Update commit to warning level Update commit to warning level Update commit to warning level Update commit to warning level Add logging to post-commit handlers Add logging to post-commit handlers revert resend confirmation to synchronous version add preprint draft relationship to user add PreprintDraftSerializer remove command file Move notification deletion to a dedicated view and remove obsolete duplicate notification handling logic. ...
uditijmehta
pushed a commit
to uditijmehta/osf.io
that referenced
this pull request
Oct 4, 2024
## Purpose The preprint draft list includes deleted preprints, that's a litttle strange, lets fix that. ## Changes - uses view query for filter out preprints that have been deleted - adds test cases Co-authored-by: John Tordoff <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The preprint draft list includes deleted preprints, that's a litttle strange, lets fix that.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-6012