Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10687 Another Replay #10739

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Sep 5, 2024

Replay of #10687 with cherry-pick

In addition the target branch feature/preprints-affiliations-test-merge-issue-3 is out-of-date with develop (17 commits behind)

api/base/permissions.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-05 at 19 48 13

cslzchen added a commit to cslzchen/osf.io that referenced this pull request Sep 6, 2024
@cslzchen cslzchen force-pushed the feature/preprints-affiliations-test-merge-issue-4 branch from 7f2b2c3 to 3d3289c Compare September 6, 2024 00:27
@cslzchen cslzchen closed this Sep 6, 2024
cslzchen added a commit that referenced this pull request Sep 6, 2024
…tributor (#10741)

* reorganize tests to ensure contributor permissions visible
* allow read permissions for non-public contributors
* fix testing issues and clean-up permissions changes
* fix up author assertion permissions to be admin only
* change test file name
* improve tests institution relationship add affiliation addition/removal
* Sync diff between #10739 and #10687
* Fix flake8
* Fix WriteOrPublicForRelationshipInstitutions for nodes
* Fix incorrect `.can_edit()` call for preprints

---------

Co-authored-by: John Tordoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant