-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10687 Another Replay #10739
Closed
cslzchen
wants to merge
10
commits into
CenterForOpenScience:feature/preprints-affiliations-test-merge-issue-3
from
cslzchen:feature/preprints-affiliations-test-merge-issue-4
Closed
#10687 Another Replay #10739
cslzchen
wants to merge
10
commits into
CenterForOpenScience:feature/preprints-affiliations-test-merge-issue-3
from
cslzchen:feature/preprints-affiliations-test-merge-issue-4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
commented
Sep 5, 2024
api_tests/preprints/views/test_preprint_institutions_relationship.py
Outdated
Show resolved
Hide resolved
cslzchen
commented
Sep 5, 2024
api_tests/preprints/views/test_preprint_detail_author_assertions.py
Outdated
Show resolved
Hide resolved
cslzchen
commented
Sep 5, 2024
cslzchen
commented
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cslzchen
added a commit
to cslzchen/osf.io
that referenced
this pull request
Sep 6, 2024
cslzchen
force-pushed
the
feature/preprints-affiliations-test-merge-issue-4
branch
from
September 6, 2024 00:27
7f2b2c3
to
3d3289c
Compare
cslzchen
added a commit
that referenced
this pull request
Sep 6, 2024
…tributor (#10741) * reorganize tests to ensure contributor permissions visible * allow read permissions for non-public contributors * fix testing issues and clean-up permissions changes * fix up author assertion permissions to be admin only * change test file name * improve tests institution relationship add affiliation addition/removal * Sync diff between #10739 and #10687 * Fix flake8 * Fix WriteOrPublicForRelationshipInstitutions for nodes * Fix incorrect `.can_edit()` call for preprints --------- Co-authored-by: John Tordoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replay of #10687 with cherry-pick
In addition the target branch feature/preprints-affiliations-test-merge-issue-3 is out-of-date with
develop
(17 commits behind)