[dev experience] unclobbering metrics tests #10747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename the `es` pytest marker to `es_metrics` (for clarity)
- update the effect of that marker:
- patch a prefix to each metric class's index and template names
- instead of deleting ALL indexes and index templates, delete only
those with the patched prefix
aaxelb
force-pushed
the
fix/unclobbering-metrics-tests
branch
from
acb4f3b
to
6d33ade
Compare
|
cherry-picked into #10742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
when running tests that use elasticsearch-metrics, the test setup/teardown clobbers all existing indexes and index templates in the local environment, which is surprising and annoying when those indexes have been set up and populated with data
Changes
espytest marker toes_metrics(for clarity)QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket