-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6185][ENG-6186][ENG-6187][ENG-6188] additional searchable metadata for institutional dashboard #10779
Merged
aaxelb
merged 5 commits into
CenterForOpenScience:feature/insti-dash-improv
from
aaxelb:feature/insti-dash-metadata-adds
Oct 25, 2024
Merged
[ENG-6185][ENG-6186][ENG-6187][ENG-6188] additional searchable metadata for institutional dashboard #10779
aaxelb
merged 5 commits into
CenterForOpenScience:feature/insti-dash-improv
from
aaxelb:feature/insti-dash-metadata-adds
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
from
October 18, 2024 14:48
43a8475
to
45a1629
Compare
aaxelb
changed the title
Feature/insti dash metadata adds
[ENG-6188] addl searchable metadata for institutional dashboard
Oct 18, 2024
aaxelb
changed the title
[ENG-6188] addl searchable metadata for institutional dashboard
[wip][ENG-6188] addl searchable metadata for institutional dashboard
Oct 18, 2024
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
8 times, most recently
from
October 21, 2024 15:53
68742fb
to
33bb4f3
Compare
aaxelb
changed the title
[wip][ENG-6188] addl searchable metadata for institutional dashboard
[wip][ENG-6185][ENG-6186][ENG-6187][ENG-6188] addl searchable metadata for institutional dashboard
Oct 21, 2024
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
3 times, most recently
from
October 21, 2024 20:49
2c15ccd
to
b4720f6
Compare
aaxelb
changed the title
[wip][ENG-6185][ENG-6186][ENG-6187][ENG-6188] addl searchable metadata for institutional dashboard
[wip][ENG-6185][ENG-6186][ENG-6187][ENG-6188] additional searchable metadata for institutional dashboard
Oct 22, 2024
aaxelb
changed the title
[wip][ENG-6185][ENG-6186][ENG-6187][ENG-6188] additional searchable metadata for institutional dashboard
[ENG-6185][ENG-6186][ENG-6187][ENG-6188] additional searchable metadata for institutional dashboard
Oct 24, 2024
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
2 times, most recently
from
October 24, 2024 14:52
0bba13d
to
44427ba
Compare
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
from
October 24, 2024 18:44
44427ba
to
462fae4
Compare
aaxelb
commented
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(comments from group review)
osf_tests/metadata/expected_metadata_files/project_monthly_supplement.turtle
Outdated
Show resolved
Hide resolved
LGTM, Abram found a few minor things that he will address, but no major blockers. |
cslzchen
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
aaxelb
force-pushed
the
feature/insti-dash-metadata-adds
branch
from
October 25, 2024 17:23
462fae4
to
19be71b
Compare
aaxelb
merged commit Oct 25, 2024
ddb46d8
into
CenterForOpenScience:feature/insti-dash-improv
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add searchable metadata that will be used by the new™️ institutional dashboard
Changes
(recommend reading commit-by-commit)
osf:hasOsfAddon
property (supplemental)urn:osf.example:addons:...
osf:storageRegion
property (supplemental)https://api.osf.example/v2/regions/.../
prov:qualifiedAttribution
(non-supplemental)osf:admin-contributor
,osf:write-contributor
, orosf:readonly-contributor
(and could add more nuanced/helpful contributor roles in the future)osf:storageByteCount
property (supplemental)update_storage_usage_cache
:compute_storage_usage_total
for the actual queryContentType.objects.get_for_model()
call (which also allows for non-node file targets)get_storage_usage_total
function (alternative toNode.storage_usage
that waits for it to compute)QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
prov:qualifiedAttribution
: ENG-6185osf:storageRegion
: ENG-6186osf:storageByteCount
: ENG-6187osf:hasOsfAddon
: ENG-6188