-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4438] Add OOPSpam and Akismet metrics to spam report #10783
[ENG-4438] Add OOPSpam and Akismet metrics to spam report #10783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick Drive-By CR. One functional issue that needs fixing in a couple places, and some smaller things preventing the build from passing.
Please also add a Deployment Note in the PR description that, because the metric report is changing, sync_metrics
will need to be ran
e93994a
to
5d9f924
Compare
5d9f924
to
1c35276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code/tests itself LGTM, however in reviewing the ticket and considering the request, two relevant considerations came up:
- Description, comments on this ticket indicate that it should be in a private metrics Report, but it isn't clear whether this information should be in a new private Report, or if it should be added to the SpamCountReporter (as it currently is) and that report should be made private.
Recommendation: seek clarity from Product regarding this. In either case, some additional work will be required - The spirit of this request is in seeking clarity on true-vs-false positive rates of automatic spam classification, however this PR only address Nodes. Preprints are another, perhaps larger category of spam, and we may want to extend this functionality to Preprints as well.
Recommendation: Confirm if that is desired by Product, and if so add acategory
param to theget_*_count
fn's to keep things DRY, and conditionally usePreprintLog
,preprint__spam_data__<etc>
instead. Extend report, tests as appropriate.
Pass complete
39f9526
to
f862984
Compare
f862984
to
771830b
Compare
@mfraezz I checked in with Product, and based on that, I made the updates—set up a new private metrics report, included preprints, and added the category parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one minor comment, code here looks good. 🍔
However, in order for the new report to run on the monthly cadence, it will also need to be added to the AllMonthlyReporters
Enum
in osf/metrics/reporters/__init__
Should be ready to merge after that. Pass complete
There may be a follow-up ticket created to make this new report available, with adequate permissions restrictions, in the metrics API. However, I expect that to be enough work to merit its own ticket, so can be deferred for now.
a1770a6
into
CenterForOpenScience:feature/b-and-i-24-22
Purpose
Add OOPSpam and Akismet metrics to track flagged and hammed content
Changes
Ticket
(https://openscience.atlassian.net/browse/ENG-4438)
Deployment Note: Because the metric report has changed, it will be necessary to run sync_metrics to apply these changes to the updated spam metrics report.