Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fetching settings from GV side #10789

Conversation

opaduchak
Copy link
Contributor

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good except for the test failure:

=========================== short test summary info ============================
FAILED osf_tests/test_gv_utils.py::TestEphemeralSettings::test_make_ephemeral_node_settings - 
requests.exceptions.ConnectTimeout: HTTPConnectionPool(host='192.168.168.167', port=8004): 
Max retries exceeded with url: /v1/configured-storage-addons/1/waterbutler-credentials (Caused by
ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f2e40906900>, 
'Connection to 192.168.168.167 timed out. (connect timeout=None)'))
=== 1 failed, 3334 passed, 29 skipped, 23823 warnings in 1540.67s (0:25:40) ====

@brianjgeiger brianjgeiger merged commit 9113097 into CenterForOpenScience:feature/gravy_valet_integration Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants