[ICA][ENG-6995] Add Curator with Correct Permissions #10936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
add-curator-with-correct-permissions
branch
from
ecdd6b6 to
cdf05a0
Compare
Johnetordoff
changed the title
brianjgeiger
approved these changes
Jan 23, 2025
Johnetordoff
changed the base branch from
feature/institutional_access
to
develop
…ine add contributor method
Johnetordoff
force-pushed
the
add-curator-with-correct-permissions
branch
from
cdf05a0 to
25a360f
Compare
Johnetordoff
merged commit f396c5a
into
CenterForOpenScience:feature/b-and-i-25-01
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This will make sure curator is added with listed permisssions. While permissions are currenlt displayed correct this PR will better pass them from the access request object to the node better, in a way that follows the business logic where
requested_permissionsdefines the given permission when the request is accepted.Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-6995