Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-3520] Remove Quickfiles Code #9870

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

[ENG-3520] Remove Quickfiles Code #9870

wants to merge 18 commits into from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Feb 1, 2022 •
edited
Loading

Purpose

Remove remaining vestigial quickfiles code that was started in this PR.

Changes

  • removes words quickfiles from comments and docs
  • removes logical checks for quickfiles
  • removes QuickFilesSerializer and QuickFilesDetailSerializer
  • removes v2 UserQuickFiles view
  • removes osf/management/commands/fix_quickfiles_waterbutler_logs.py, osf/management/commands/reindex_quickfiles.py, osf/management/commands/transfer_quickfiles_to_projects.py
  • add conditional migration completely removing quickfiles.

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-3520

@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 2 times, most recently from 3a90533 to ef2e101 Compare February 1, 2022 19:40
@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 3 times, most recently from 3f07bf0 to f2785f7 Compare March 16, 2022 11:12
@Johnetordoff Johnetordoff marked this pull request as ready for review March 16, 2022 15:54
John Tordoff added 2 commits March 21, 2022 08:07
@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 12 times, most recently from 8cce738 to 5c3e013 Compare March 24, 2022 20:01
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
f86d345 
 into remove-quickfiles-code

# Conflicts:
#	api_tests/files/views/test_file_detail.py
#	osf/models/quickfiles.py
#	scripts/remove_after_use/verify_groups_guardian_migration.py
#	tests/test_addons.py
#	tests/test_views.py
#	website/search/elastic_search.py
#	website/static/js/components/quickFiles.js
#	website/templates/include/profile/names.mako
@Johnetordoff Johnetordoff changed the title Remove quickfiles Code [ENG-3510] Remove quickfiles Code Aug 15, 2022
@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 2 times, most recently from ce4c186 to c29881a Compare August 16, 2022 17:34
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
1341f59 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io: (44 commits)
  Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022)
  Update shield logo for colorado (UC Boulder)
  Update description for maglab
  [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009)
  "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003)
  Add new instn purdue
  Ensure BitBucket token is string, not bytes
  Only redirect to cas if not logged in
  OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
  [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989)
  Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986)
  [ENG-3894] Outcome models (CenterForOpenScience#9975)
  revert color picker to working version (CenterForOpenScience#9968)
  Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID
  Add a django command script to handle instn sso email domain changes
  Bump version and CHANGELOG
  Add better logic for routing Dataverse files and their stupid duplicate (CenterForOpenScience#9963)
  [ENG-3872] Fix dataverse 502s and pass version info to FE (CenterForOpenScience#9959)
  Fix File `show_as_unviewed` behavior (CenterForOpenScience#9960)
  Fix OSFUser.has_resources
  ...

# Conflicts:
#	api_tests/files/views/test_file_detail.py
#	osf/models/nodelog.py
#	osf/models/user.py
#	tests/test_addons.py
#	website/static/js/anonymousLogActionsList.json
#	website/static/js/logActionsList.json
John Tordoff added 3 commits September 16, 2022 08:06
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
ea0d562 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Bump version and update CHANGELOG
  [ENG-3568] keen replacement (CenterForOpenScience#9954)
  Bump NR Agent version
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  Update test-build.yml
  Bump version and update CHANGELOG
  [ENG-3854] Add management command to sync all DOI metadata (CenterForOpenScience#9972)

# Conflicts:
#	scripts/analytics/file_summary.py
#	website/settings/defaults.py
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
5c5fd2f 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io: (66 commits)
  Bump version and update changelog.
  datacite:publicationYear is stricter than dcterms:dateCopyrighted (CenterForOpenScience#10339)
  tests for osf.metadata (CenterForOpenScience#10321)
  [ENG-4286][ENG-4308] Spam Metrics and Async tasks (CenterForOpenScience#10325)
  bugfixes for weird historical data in metrics backfills
  revert accessibility fix
  Bump version and update CHANGELOG
  [ENG-4360] Feature/keen replacement admin (CenterForOpenScience#10270)
  Add auto-generated migration (CenterForOpenScience#10327)
  Bump Django patch version
  Bump version and update CHANGELOG
  [ENG-4239] Collection Moderation post-release BE (CenterForOpenScience#10294)
  Update CHANGELOG and bump version
  fix: gatherer should not assume full fundinginfo
  set guid-metadata required scopes
  fix: tighten funder validation, "no license" handling
  fix migration conflicts
  [ENG-4056] guid metadata download (CenterForOpenScience#10292)
  Fix perm typo
  Add instituionassetfile perms to migrate signals
  ...

# Conflicts:
#	api/files/views.py
#	api/users/urls.py
#	osf/migrations/0054_auto_20170823_1555.py
#	osf/migrations/0088_post_migrate_collections.py
#	osf/migrations/0198_draft_node_models.py
#	osf/models/mixins.py
#	osf/models/user.py
#	tests/test_views.py
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
5b8525f 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Re-implement improved Node/Registration anonymization from PR 10009 (CenterForOpenScience#10343)
  [ENG-4201] Remove deprecated department, affiliated institutions, logo and banner from models (CenterForOpenScience#10326)
  fix filtering
  fix report date sorting to deal with monthly reports
  Fix definition of report_yearmonth
@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 3 times, most recently from 53dc7d6 to 758bc49 Compare March 7, 2023 18:41
@Johnetordoff Johnetordoff changed the title [ENG-3510] Remove quickfiles Code [ENG-3510] Remove Quickfiles Code Mar 7, 2023
@Johnetordoff Johnetordoff force-pushed the remove-quickfiles-code branch 2 times, most recently from ee9767a to 224b9f6 Compare March 7, 2023 19:38
@Johnetordoff Johnetordoff changed the title [ENG-3510] Remove Quickfiles Code [ENG-3520] Remove Quickfiles Code Mar 7, 2023
@Johnetordoff Johnetordoff reopened this May 3, 2024
John Tordoff added 2 commits July 25, 2024 05:03
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
7753948 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io: (166 commits)
  update dataverse dep revision to get changes
  Update CHANGELOG, bump version
  [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648)
  Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666)
  Check Registration READ perms on the Registration - Do not record download metrics for renders
  Fix signature
  Allow DOI metadata updates to be queued
  [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)
  Update CHANGELOG, bump version
  [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617)
  Update CHANGELOG, bump version
  Ensure Assumed-HAM users do not get autobanned
  [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643)
  [ENG-5718] Use `make_auth` to avoid assumptions about `auth.user` (CenterForOpenScience#10647)
  [ENG-5699] Framework for getting Addon Info from GV (CenterForOpenScience#10641)
  [ENG-5178] Allow unauthenticated users to see public files (CenterForOpenScience#10645)
  Fix RelationshipPostMakesNoChanges exception in project creation (CenterForOpenScience#10644)
  [ENG - 5008] Support Unicode and special characters in file names during archiving (CenterForOpenScience#10627)
  Set Default Resource Type for Registrations to "Study Registration" (CenterForOpenScience#10636)
  Configurable GV Mock + HMAC Auth (CenterForOpenScience#10623)
  ...

# Conflicts:
#	addons/base/views.py
#	api/caching/tasks.py
#	api_tests/files/views/test_file_detail.py
#	api_tests/wb/views/test_wb_hooks.py
#	osf/management/commands/data_storage_usage.py
#	osf/management/commands/reindex_quickfiles.py
#	osf/management/commands/transfer_quickfiles_to_projects.py
#	osf/models/__init__.py
#	osf/models/private_link.py
#	osf/models/quickfiles.py
#	osf/models/user.py
#	scripts/fix_merged_user_quickfiles.py
#	tests/test_views.py
#	website/mails/mails.py
#	website/search/elastic_search.py
#	website/settings/defaults.py
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
7374b56 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Hotfixes for: double-encoded urls + dep upgrades
  fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697)
  use correct version of module for metrics
  update Dockerfile for recent lints
  remove deprecated version stanza from docker-composes
  update reqs to pull from github commit shas
  correct body location for api.ia POST requests
John Tordoff and others added 2 commits August 23, 2024 14:42
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
9d77272 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Hotfixes for: double-encoded urls + dep upgrades
  fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697)
  use correct version of module for metrics
  update Dockerfile for recent lints
  remove deprecated version stanza from docker-composes
  update reqs to pull from github commit shas
  correct body location for api.ia POST requests
@Johnetordoff
Merge branch 'develop' into remove-quickfiles-code
7b48a6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Johnetordoff