refactor: item service 코드 스멜 제거

Central-MakeUs · Jan 19, 2024 · eb1b0c8 · eb1b0c8
1 parent c427dc8
commit eb1b0c8
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/api/src/main/java/com/mm/api/Item/service/ItemService.java b/api/src/main/java/com/mm/api/Item/service/ItemService.java
@@ -74,6 +74,10 @@ public ItemResponse updateItem(Long id, ItemUpdateRequest request) {
         return ItemResponse.of(item);
     }
 
+    public void deleteItem(Long id) {
+        itemRepository.deleteById(id);
+    }
+
     private ItemUpdate getItemUpdate(ItemUpdateRequest request) {
         return ItemUpdate.builder()
                 .detail(request.detail())
@@ -86,31 +90,25 @@ private ItemUpdate getItemUpdate(ItemUpdateRequest request) {
                 .build();
     }
 
-    public void deleteItem(Long id) {
-        itemRepository.deleteById(id);
-    }
-
     private List<ItemVideo> getItemVideos(List<String> videoUrls, Item item) {
-        List<ItemVideo> itemVideos = videoUrls
+        return videoUrls
                 .stream()
                 .map(url ->
                         ItemVideo.builder()
                                 .url(url)
                                 .item(item)
                                 .build())
                 .toList();
-        return itemVideos;
     }
 
     private List<ItemImage> getItemImages(List<String> imageUrls, Item item) {
-        List<ItemImage> itemImages = imageUrls
+        return imageUrls
                 .stream()
                 .map(url ->
                         ItemImage.builder()
                                 .url(url)
                                 .item(item)
                                 .build())
                 .toList();
-        return itemImages;
     }
 }