Merge pull request #61 from Central-MakeUs/fix/2

Fix/2 🔨 ✨ 피어테스트 관련 api 형식 수정, uuid로 유저 이름 조회 API 구현

src/main/java/cmc/peerna/apiResponse/code/ResponseStatus.java

@@ -25,6 +25,8 @@ public enum ResponseStatus implements BaseCode {
     // member 에러
     MEMBER_NOT_FOUND(OK, 2200, "존재하지 않는 유저입니다."),
 
+    // test 에러
+    UUID_NOT_FOUND(OK, 2250, "잘못된 UUID 값입니다."),
 
     // 400번대 에러
 

src/main/java/cmc/peerna/repository/PeerFeedbackRepository.java

@@ -7,11 +7,12 @@
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.List;
+import java.util.Optional;
 import java.util.UUID;
 
 public interface PeerFeedbackRepository extends JpaRepository<PeerFeedback, Long> {
 
-    PeerFeedback findByNonMemberUuid(String nonMemberUuid);
+    Optional<PeerFeedback> findByNonMemberUuid(String nonMemberUuid);
 
     List<PeerFeedback> findTop3ByTargetOrderByCreatedAtDesc(Member target);
 

src/main/java/cmc/peerna/service/serviceImpl/MemberServiceImpl.java

@@ -99,7 +99,7 @@ public void updateTotalScore(Member member) {
 
     @Override
     public Member findMemberByUuid(String uuid) {
-        Member member = memberRepository.findByUuid(uuid).orElseThrow(() -> new MemberException(ResponseStatus.MEMBER_NOT_FOUND));
+        Member member = memberRepository.findByUuid(uuid).orElseThrow(() -> new MemberException(ResponseStatus.UUID_NOT_FOUND));
         return member;
     }
 

src/main/java/cmc/peerna/service/serviceImpl/TestServiceImpl.java

@@ -19,6 +19,7 @@
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
+import java.util.Optional;
 import java.util.stream.Collectors;
 
 @Service
@@ -163,7 +164,8 @@ public void savePeerGradeResult(Member writer, Member target, PeerGrade peerGrad
     @Transactional
     public void updatePeerTestMemberId(Member member, String uuid) {
 
-        PeerFeedback peerFeedback = peerFeedbackRepository.findByNonMemberUuid(uuid);
+        PeerFeedback peerFeedback = peerFeedbackRepository.findByNonMemberUuid(uuid).orElseThrow(() -> new TestException(ResponseStatus.UUID_NOT_FOUND));
+
         peerFeedback.updateWriter(member);
 
         PeerGradeResult peerGradeResult = peerGradeResultRepository.findByNonMemberUuid(uuid);

src/main/java/cmc/peerna/web/controller/MemberController.java

@@ -182,5 +182,18 @@ else if (page < 1)
     public ResponseDto<MemberRequestDto.profileUpdateDto> updateMemberProfile(@AuthMember Member member, @RequestBody MemberRequestDto.profileUpdateDto request) {
         return ResponseDto.of(memberService.updateMemberProfile(member, request));
     }
+
+    @Operation(summary = "UUID로 유저 이름 조회 API ✔️🔑", description = "UUID로 유저 이름 조회 API입니다.")
+    @ApiResponses({
+            @ApiResponse(responseCode = "2250", description = "BAD_REQUEST, 잘못된 UUID 값입니다."),
+    })
+    @Parameters({
+            @Parameter(name = "member", hidden = true)
+    })
+    @GetMapping("member/name")
+    public ResponseDto<MemberResponseDto.memberNameResponseDto> getUserNameByUuid(@RequestParam(name = "uuid") String uuid) {
+        Member memberByUuid = memberService.findMemberByUuid(uuid);
+        return ResponseDto.of(MemberResponseDto.memberNameResponseDto.builder().name(memberByUuid.getName()).build());
+    }
 }
 

src/main/java/cmc/peerna/web/controller/TestController.java

@@ -88,11 +88,11 @@ public ResponseDto<TestResponseDto.selfTestResultResponseDto> getSelfTestResult(
 
     @Operation(summary = "비회원 피어 테스트 작성 API ✔️", description = "비회원 피어 테스트 작성 API입니다.")
     @ApiResponses({
-            @ApiResponse(responseCode = "2200", description = "BAD_REQUEST, 존재하지 않는 유저입니다."),
+            @ApiResponse(responseCode = "2250", description = "BAD_REQUEST, 잘못된 UUID 값입니다."),
             @ApiResponse(responseCode = "4200", description = "BAD_REQUEST, 잘못된 답변 ID 값을 전달했습니다."),
             @ApiResponse(responseCode = "4201", description = "BAD_REQUEST, 답변 개수가 정확하게 18개가 아닙니다.")
     })
-    @PostMapping("/review/peer-test/{target-uuid}")
+    @PostMapping("/review/peer-test")
     public ResponseDto<TestResponseDto.peerTestIdResponseDto> savePeerTest(@RequestParam(name = "target-uuid") String targetUuid,  @RequestBody TestRequestDto.peerTestRequestDto requestDto) {
         Member target = memberService.findMemberByUuid(targetUuid);
         testService.savePeerTest(null, target, requestDto);
@@ -103,11 +103,12 @@ public ResponseDto<TestResponseDto.peerTestIdResponseDto> savePeerTest(@RequestP
 
     @Operation(summary = "비회원 유저 회원가입 후 id값 갱신용 API ✔️🔑", description = "비회원 유저 회원가입 후 id값 갱신용 API입니다.")
     @ApiResponses({
-            @ApiResponse(responseCode = "2200", description = "BAD_REQUEST, 존재하지 않는 유저입니다.")
+            @ApiResponse(responseCode = "2200", description = "BAD_REQUEST, 존재하지 않는 유저입니다."),
+            @ApiResponse(responseCode = "2250", description = "BAD_REQUEST, 해당 UUID로 작성된 정보가 존재하지 않습니다. 잘못된 UUID 값 입니다."),
     })
     @PostMapping("/review/update-member-id")
-    public ResponseDto<MemberResponseDto.MemberStatusDto> updateMemberId(@AuthMember Member member, @RequestBody String uuid) {
-        testService.updatePeerTestMemberId(member, uuid);
+    public ResponseDto<MemberResponseDto.MemberStatusDto> updateMemberId(@AuthMember Member member, @RequestBody MemberRequestDto.uuidRequestDto uuid) {
+        testService.updatePeerTestMemberId(member, uuid.getUuid());
         return ResponseDto.of(MemberConverter.toMemberStatusDto(member.getId(), "UpdatePeerTestWriterId"));
     }
 

src/main/java/cmc/peerna/web/dto/requestDto/MemberRequestDto.java

@@ -43,4 +43,12 @@ public static class profileUpdateDto{
         private Part part;
         private String oneLiner;
     }
+
+    @Builder
+    @Getter
+    @AllArgsConstructor(access = AccessLevel.PROTECTED)
+    @NoArgsConstructor(access = AccessLevel.PROTECTED)
+    public static class uuidRequestDto{
+        private String uuid;
+    }
 }

src/main/java/cmc/peerna/web/dto/responseDto/MemberResponseDto.java

@@ -53,4 +53,12 @@ public static class memberBasicInfoDto{
         private String uuid;
     }
 
+    @Builder
+    @Getter
+    @AllArgsConstructor(access = AccessLevel.PROTECTED)
+    @NoArgsConstructor(access = AccessLevel.PROTECTED)
+    public static class memberNameResponseDto{
+        private String name;
+    }
+
 }