feat: bottomNavigationLayout 구현 및 lefthook 설정 수정 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfumeplaylist
changed the title
Inoansta
reviewed
Jan 28, 2025
Comment on lines
+1
to
+5
| import { SvgProps } from './SettingIcon'; | ||
|
|
||
| export const HomeIcon = ({ color, className }: SvgProps) => { | ||
| return ( | ||
| <svg |
There was a problem hiding this comment.
svg를 전부 tsx로 바꾸셔서 링크 오류가 나는 거였군요 이렇게 하면 color를 바꿀 수 있다는 장점이 있네요
머지 후 수정하겠습니다
|
|
||
| function UserInformationProfiles() { | ||
| return ( | ||
| <div className={'flex flex-row mt-[20px] items-center'}> | ||
| <SparkIcon style={{ width: '48px', height: '48px' }} /> | ||
| <SparkIcon className={'w-12 h-12'} /> |
There was a problem hiding this comment.
이런경우 각 픽셀에 맞는 tailwind숫자를 찾기어려우니 []안에 크기를 삽입하셔도 됩니다
ex) 'w-[48px] h-[48px]'
Comment on lines
+11
to
+22
| const linkConfig = { | ||
| home: { | ||
| path: '/', | ||
| title: '홈', | ||
| icon: HomeIcon, | ||
| }, | ||
| setting: { | ||
| path: '/setting', | ||
| title: '설정', | ||
| icon: SettingIcon, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
linkConfig 전체를 배열이 아니라 객체인 이유가 있을까요? 굳이 Object.value후 mapping을 하는 이유가 궁금합니다
Comment on lines
+24
to
+30
| function Navigation({ path, icon: Icon, title }: NavLinkProps) { | ||
| return ( | ||
| <section className={'flex-1 py-2 cursor-pointer'}> | ||
| <NavLink to={path}> | ||
| {({ isActive }) => ( | ||
| <div className={'flex flex-col items-center'}> | ||
| <Icon color={isActive ? 'black' : 'gray-500'} /> |
There was a problem hiding this comment.
밖으로 빼라는 말씀이 파일을 하나더 만들라는 뜻인줄 알았는데 이렇게 선언해도 재생성으로 부터 피해갈 수 있겠네요!
Inoansta
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
2025-01-28.10.42.20.mov
pr 포인트나 궁금한 점을 작성해 주세요
연관된 issue: #undefined