Updates for glTF extension validation #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies the PR at CesiumGS/3d-tiles-validator#280
The changes that are done here:
GltfUtilities
contained a functionextractJsonFromGlb
that only sliced out the JSON buffer from a glTF 1.0 or glTF 2.0 GLB file. There was not function for obtaining the binary buffer. This has been generalized into a functionextractDataFromGlb
that returns the JSON buffer and the binary buffer.BinaryPropertyTable
originally contained thepropertyTable
and individual properties that together defined the binary representation of the metadata (independent of whether it was part of a property table or not). The parts that define the binary metadata have now been summarized in aBinaryMetadata
structure.ENUM
properties and their binary representation had some issues that are supposed to be fixed here. Details are given in Binary representations of enum values are not translated #71