Merge pull request #672 from CesiumGS/fix-scene-reload-crash

Fix crash on scene reload

CHANGES.md

@@ -5,6 +5,7 @@
 * Added support for globe anchors on non-georeferenced tilesets.
 * Fixed zooming to tileset extents when tileset prims have non identity transformation.
 * Fixed crash when updating tilesets shader inputs.
+* Fixed crash when setting certain `/Cesium` debug options at runtime.
 
 ### v0.17.0 - 2024-02-01
 

src/core/src/FabricMaterial.cpp

@@ -530,13 +530,20 @@ FabricMaterial::FabricMaterial(
 }
 
 FabricMaterial::~FabricMaterial() {
-    if (stageDestroyed()) {
-        return;
-    }
-
-    for (const auto& path : _allPaths) {
-        FabricUtil::destroyPrim(_pContext->getFabricStage(), path);
-    }
+    // The code below is temporarily commented out to avoid a crash.
+    // It will cause a leak, but since this only happens when materials
+    // pools are destroyed (which doesn't happen during normal usage) it
+    // shouldn't be a huge concern.
+    //
+    // See https://github.com/CesiumGS/cesium-omniverse/issues/444 for details.
+
+    // if (stageDestroyed()) {
+    //     return;
+    // }
+
+    // for (const auto& path : _allPaths) {
+    //     FabricUtil::destroyPrim(_pContext->getFabricStage(), path);
+    // }
 }
 
 void FabricMaterial::setActive(bool active) {