Fix cesium:debug:randomColors with vertex colors
#497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
requested review from
weegeekps,
r-veenstra,
corybarr and
mattelser
as code owners
lilleyse
force-pushed
the
fix-debug-color
branch
from
26954e2 to
991ac3a
Compare
corybarr
reviewed
Oct 19, 2023
| @@ -158,7 +153,7 @@ void FabricGeometry::initialize() { | |||
| } | |||
|
|
|||
| if (hasVertexColors) { | |||
| attributes.addAttribute(FabricTypes::primvars_vertexColor, FabricTokens::primvars_vertexColor); | |||
There was a problem hiding this comment.
Is the vertexColor attribute never going to be used going forward for anything, such as styling?
There was a problem hiding this comment.
Ah, I see. Got it. Nevermind.
There was a problem hiding this comment.
Yeah it's basically just a rename from vertexColor to displayColor. Trying to be more consistent with USD conventions.
corybarr
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429. Previously
randomColorswould have no affect for tiles with vertex colors (including point clouds).Now that we have our own
cesium_materialshader I went with option 1 in #429.Test data: vertex-color.zip
randomColorsrandomColors