Imagery layer alpha control #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
requested review from
weegeekps,
r-veenstra,
corybarr and
mattelser
as code owners
weegeekps
approved these changes
Oct 20, 2023
| string apiName = "alpha" | ||
| } | ||
| displayName = "Alpha" | ||
| doc = "The alpha blending value, from 0.0 to 1.0." |
There was a problem hiding this comment.
NIT: We should probably mention in the doc that 1.0 means fully opaque.
lilleyse
commented
Oct 20, 2023
| @@ -467,7 +467,7 @@ void FabricPrepareRenderResources::attachRasterInMainThread( | |||
|
|
|||
| const auto texcoordIndex = mesh.imageryTexcoordIndexMapping.at(gltfSetIndex); | |||
| const auto& textureAssetPath = texture->getAssetPathToken(); | |||
| material->setImageryLayer(textureAssetPath, textureInfo, texcoordIndex, imageryLayerIndex.value()); | |||
| material->setImageryLayer(textureAssetPath, textureInfo, texcoordIndex, imageryLayerIndex.value(), 1.0f); | |||
There was a problem hiding this comment.
I forgot to un-hardcode this value. Will have a fix pushed soon.
There was a problem hiding this comment.
Oh, I thought that was intentional. Ok, I'll review again when you've pushed a fix.
There was a problem hiding this comment.
8d0a9cd - ready for review
This was referenced Oct 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
alphaproperty toCesiumImageryPrimas a quick and easy way to control the translucency of an imagery layer.Technically this could also be achieved with tileset materials (like the example here) but it would be slower and would require a tileset reload (currently).
For testing: multiple.usda.zip