Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass loading of clipped tiles #658

Merged
merged 24 commits into from
Feb 15, 2024
Merged

Bypass loading of clipped tiles #658

merged 24 commits into from
Feb 15, 2024

Conversation

corybarr
Copy link
Contributor

@corybarr corybarr commented Feb 1, 2024

Do not merge until CesiumGS/cesium-native#803 is resolved.


Add the following to functionality to polygon raster overlays:

image

(It seems tooltips don't wrap if they go off the screen.)

Test file:
AustrialiaBlockClipping.zip

@lilleyse
Copy link
Contributor

lilleyse commented Feb 5, 2024

@corybarr given Kevin's comment in CesiumGS/cesium-native#803 (comment), it may be possible to test this with another dataset like Melbourne Photogrammetry (in the asset depot).

@corybarr
Copy link
Contributor Author

corybarr commented Feb 5, 2024

@corybarr given Kevin's comment in CesiumGS/cesium-native#803 (comment), it may be possible to test this with another dataset like Melbourne Photogrammetry (in the asset depot).

@lilleyse Good call. It works well and feels very snappy loading just this section:

image

Logs confirm it works.

@corybarr corybarr marked this pull request as ready for review February 5, 2024 21:03
src/core/src/OmniPolygonRasterOverlay.cpp Outdated Show resolved Hide resolved
src/core/src/OmniPolygonRasterOverlay.cpp Outdated Show resolved Hide resolved
src/core/src/OmniTileset.cpp Outdated Show resolved Hide resolved
src/core/src/OmniTileset.cpp Outdated Show resolved Hide resolved
@corybarr
Copy link
Contributor Author

corybarr commented Feb 7, 2024

@corybarr given Kevin's comment in CesiumGS/cesium-native#803 (comment), it may be possible to test this with another dataset like Melbourne Photogrammetry (in the asset depot).

@lilleyse Good call. It works well and feels very snappy loading just this section:

image

Logs confirm it works.

Clipping test for Melbourne: MelbourneClippingTest.zip

@lilleyse
Copy link
Contributor

lilleyse commented Feb 9, 2024

@corybarr I tested that CesiumGS/cesium-native#808 fixes the clipping issues with P3DT.

@corybarr
Copy link
Contributor Author

@corybarr I tested that CesiumGS/cesium-native#808 fixes the clipping issues with P3DT.

Awesome. Will update and merge after that fix merged.

@lilleyse
Copy link
Contributor

@corybarr could you update CHANGES.md?

@corybarr
Copy link
Contributor Author

@corybarr could you update CHANGES.md?

@lilleyse pushed

@lilleyse
Copy link
Contributor

@corybarr could you update cesium-native in this branch now that CesiumGS/cesium-native#808 is merged?

@corybarr
Copy link
Contributor Author

@corybarr could you update cesium-native in this branch now that CesiumGS/cesium-native#808 is merged?

cesium-native is updated. The fix is confirmed working:
image

@corybarr corybarr merged commit 6418a52 into main Feb 15, 2024
3 checks passed
@corybarr corybarr deleted the exclude-tiles-not-in-polygon branch February 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants