Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a Fabric prim with the same path as a previously destroyed prim causes a crash. Previously this was avoided by including the object id and pool id in the name, but on extension reload the pool id is initialized to 0 and new paths may conflict with old paths.
Now a contextId is randomly generated and ensures that Fabric prim paths are unique even across extension reloads.
There are probably more robust and safer ways to do this than
glm::linearRand<int64_t>(0, 100000)
, like using a timestamp, but since extension reloads are uncommon and I didn't want to overcomplicate this.With the fix applied the extension no longer crashes when disabled and re-enabled:
extension-reload.mp4