Wait for loading tiles when using the movie capture tool #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Both these are with settle latency at 0 0.17.0: GoogleOnlineNoSettle.mp4This branch: GoogleOfflineNoSettle.mp4Captures are much faster than when using an arbitary value for settle latency too! |
|
Great, I'll mark this as ready for review then |
|
Is the changing geometry in the render from this branch due to geometric error? |
corybarr
approved these changes
Feb 14, 2024
I believe so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198.
I confirmed that
updateViewOfflineis called when the movie capture tool is active, andupdateViewis called otherwise, but I haven't been able to verify the results because I'm having trouble with the Capturing Images and Video tutorial. Marking as draft until that's resolved.