-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tile Map Service (TMS) and Web Map Tile Service (WMTS) raster overlay support #691
Conversation
This appears to be functioning as expected. My only question is should there be some feedback in the console when WMTS is configured incorrectly? For example, with WMS and TMS if I put in a wrong URL, I'll usually get some form of error. However, with WMTS nothing displays in the log at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I didn't do much testing beyond loading the .usda files and trying out the new UI but the code looks consistent with WMS.
(Draft until UI polishing is complete)
Adds TMS support:
Adds WMTS support:
UI/UX Notes:
This PR hides them instead. I didn't find an obvious way to gray them out.
While Omniverse supports string[] parameters, they aren't by default editable in the UI:
In this PR, users supply the strings comma-separated.
I don't have an example to test all settings. "Tiling Scheme Settings" is currently untested:
I hit some limitations trying to visually group parameters in the custom attribute widgets. In particular omni.ui.Line didn't appear. The UI is functional, but the UX and in particular visual groupings could use improvement.
reloading the tileset every time a property is changed is probably not ideal. See Spec and implement improved UI/UX for refreshing and reloading tilesets and raster overlays #676