Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gsl::span with std::span #529

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Replace gsl::span with std::span #529

merged 3 commits into from
Nov 26, 2024

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Nov 21, 2024

This updates cesium-native to the latest main, and removes mentions of gsl now that CesiumGS/cesium-native#977 is merged.

@j9liu
Copy link
Contributor Author

j9liu commented Nov 21, 2024

CI is failing for the arm64 Android build because of this:

D:/.ezvcpkg/2024.11.16/installed/arm64-android-unity/include\absl/time/time.h:1762:37: error: invalid operands to binary expression ('std::strong_ordering' and 'const std::strong_ordering')
  if (auto c = lhs_hi <=> rhs_hi; c != std::strong_ordering::equal) 

Strange 🤔 seems like something with our dependencies?

@kring
Copy link
Member

kring commented Nov 22, 2024

That's a bug in Abseil, triggered by a limitation in the old compiler used on Android. I fixed it in Unreal in CesiumGS/cesium-unreal#1539 by adding an overlay port of Abseil that hacks in a fix for the Abseil bug.

@kring
Copy link
Member

kring commented Nov 22, 2024

This is the Abseil bug:
abseil/abseil-cpp#1728

@j9liu
Copy link
Contributor Author

j9liu commented Nov 25, 2024

Thanks for the help @kring . It looks like CI is happy now! 🥲

@kring
Copy link
Member

kring commented Nov 26, 2024

Thanks @j9liu!

@kring kring merged commit 893ae40 into main Nov 26, 2024
7 checks passed
@kring kring deleted the remove-gsl branch November 26, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants