-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix 2D Skeleton example thanks to @shunter 's higher order function t…
…utorial.
- Loading branch information
Showing
1 changed file
with
30 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02e377e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this change is needed. Right now, scenes are completely separate. They will remain this way for the foreseeable future until the WebGL shared contexts extension is finished, implemented, and widely available. I'd rather see a fix in the Skeleton2D example where a separate BingMapsTileProvider is used for each scene just like a separate CentralBody primitive and night lights images are used. Otherwise, we have an inconsistent API where users don't know what is shared among scenes and what is not.
Bigger picture, some types like cartesians and matrices, can, of course, be used among multiple scenes, and perhaps we need to document that at some point.
02e377e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning here was that a tile provider should return the right image no matter who requests it, but I'll change the example to be consistent.
02e377e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.