Aggregate Committee Rotation Circuit #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltea
approved these changes
Sep 5, 2023
| @@ -75,6 +75,7 @@ pub struct CommitteeUpdateCircuit<S: Spec, F: Field> { | |||
| pubkeys_compressed: Vec<Vec<u8>>, | |||
| pubkeys_y: Vec<Fq>, | |||
| dry_run: bool, | |||
| sha256_offset: usize, | |||
There was a problem hiding this comment.
sha256_offset is a relict from banshee where multiple subcircuits can use sha256 table/chip, prop can remove this safely here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Wide Sha256 circuit and compress proof using aggregation
Wide Circuit Numbers:
Application Circuit: k = 17, proving time = 55s
Aggregation Circuit: k = 22, proving time 217s
Gas Cost: 574389
Code Size: 22689
Application Circuit: k = 18, proving time = 93s
Aggregation Circuit: k = 22, proving time 215s
Gas Cost: 548935
Code Size: 21663
Tall Circuit Numbers: TBD