Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to snark-verifier Solidity contracts #61

Merged
merged 19 commits into from
Feb 21, 2024
Merged

Conversation

nulltea
Copy link
Member

@nulltea nulltea commented Feb 21, 2024

This PR switches to regular Sol contracts generated by snark-verifier and adds manual instances parcing in Spectre.sol.

Before we used modifed Yul contract generation and halo2-solidity-verifier for automatic instance parcing.

Step gas cost: 345,618 (before 400,526)
Rotate gas cost: 670,586 (before 766,145 )

This also removes patches of snark-verifier.

Constracrs are moved to https://github.com/ChainSafe/spectre-contracts and added here as submodule

lightclient-circuits/src/committee_update_circuit.rs Outdated Show resolved Hide resolved
lightclient-circuits/src/gadget/crypto/sha256_wide/gate.rs Outdated Show resolved Hide resolved
// Code: https://github.com/ChainSafe/Spectre
// SPDX-License-Identifier: LGPL-3.0-only

use ark_std::{end_timer, start_timer};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to uncomment

lightclient-circuits/src/sync_step_circuit.rs Outdated Show resolved Hide resolved
@nulltea nulltea merged commit 9642044 into main Feb 21, 2024
2 checks passed
@nulltea nulltea deleted the nulltea/misc-fixes branch February 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants