Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lighthouse Types instead of maintaining our own #77

Merged
merged 30 commits into from
Apr 4, 2024
Merged

Use Lighthouse Types instead of maintaining our own #77

merged 30 commits into from
Apr 4, 2024

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Mar 26, 2024 •
edited
Loading

Notes:

  • Prover RPC API changed to now accept ForkName as a param so we can deserialize LightClientUpdates according to which fork were on.
  • Rotation sepolia tests are failing in preprocessor (I have a feeling we can remove this test entirely and rely on test_both_circuit_sepolia)

TODO:
I am kinda annoyed that we have Lighthouses EthSpec and then our Spec trait. There is a huge overlap, so currently thinking how we can simplify this. Done

@ec2 ec2 marked this pull request as draft March 26, 2024 18:29
@ec2 ec2 changed the base branch from main to develop March 26, 2024 18:42
@ec2 ec2 marked this pull request as ready for review April 3, 2024 17:15
nulltea
nulltea requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@nulltea nulltea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks! Left some comments

lightclient-circuits/src/committee_update_circuit.rs Outdated Show resolved Hide resolved
lightclient-circuits/src/witness/multiproof.rs Show resolved Hide resolved
preprocessor/Cargo.toml Show resolved Hide resolved
preprocessor/src/lib.rs Outdated Show resolved Hide resolved
rust-toolchain Outdated Show resolved Hide resolved
test-utils/src/lib.rs Outdated Show resolved Hide resolved
prover/src/utils.rs Outdated Show resolved Hide resolved
preprocessor/src/step.rs Outdated Show resolved Hide resolved
@ec2 ec2 mentioned this pull request Apr 4, 2024
Merged
@ec2 ec2 requested a review from nulltea April 4, 2024 15:56
nulltea
nulltea approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@nulltea nulltea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ec2 ec2 merged commit 8902f51 into develop Apr 4, 2024
1 check passed
@ec2 ec2 deleted the ec2/lighthouse-types-take2 branch April 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulltea nulltea nulltea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ec2 @nulltea