Skip to content

Add fixes for feedback from Gnosis #25

Add fixes for feedback from Gnosis

Add fixes for feedback from Gnosis #25

Triggered via pull request August 25, 2023 01:49
Status Success
Total duration 18m 2s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

26 warnings
clippy and fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy and fmt
/home/runner/work/Zipline-Casper/Zipline-Casper/finality-client/Cargo.toml: unused manifest key: dependencies.typenum.feature
clippy and fmt
the following packages contain code that will be rejected by a future version of Rust: uint v0.4.1
clippy and fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy and fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy and fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy and fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build-mips / build-release
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build-mips / build-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build-mips / build-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build-mips / build-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build-mips / build-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build-release
The following actions uses node12 which is deprecated and will be forced to run on node16: arduino/[email protected], actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build-release
/home/runner/work/Zipline-Casper/Zipline-Casper/finality-client/Cargo.toml: unused manifest key: dependencies.typenum.feature
build-release
the following packages contain code that will be rejected by a future version of Rust: uint v0.4.1
test
The following actions uses node12 which is deprecated and will be forced to run on node16: arduino/[email protected], actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test
/home/runner/work/Zipline-Casper/Zipline-Casper/finality-client/Cargo.toml: unused manifest key: dependencies.typenum.feature
test: finality-client/tests/direct_state_reader.rs#L2
unused import: `self`
test
`zipline-finality-client` (test "patch") generated 1 warning (run `cargo fix --test "patch"` to apply 1 suggestion)
test: finality-client/tests/attestation_test_case/mod.rs#L17
associated items `from` and `execute` are never used
test: finality-client/tests/zipline_test_case/mod.rs#L237
associated function `from_input` is never used
test: finality-client/tests/zipline_test_case/mod.rs#L189
using `.clone()` on a double reference, which returns `&ethereum_consensus::bellatrix::SignedBeaconBlock<16, 2048, 2, 128, 16, 16, 512, 256, 32, 1073741824, 1048576>` instead of cloning the inner type
test
`zipline-finality-client` (test "verify") generated 5 warnings (1 duplicate)
test: finality-client/tests/attestation_test_case/mod.rs#L7
field `post` is never read
test
`zipline-finality-client` (test "attestation") generated 2 warnings (1 duplicate)
test
the following packages contain code that will be rejected by a future version of Rust: uint v0.4.1