Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialog-api-macro-set.js #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manonamora
Copy link
Contributor

SugarCube 2.37.3 update:
switched Dialog.setup for Dialog.create + the wiki on the popup

switched Dialog.setup for Dialog.create + the wiki on the popup
@ChapelR
Copy link
Owner

ChapelR commented Aug 10, 2024

This would break support for versions older than 2.36, right? That would be a breaking change for older versions so it's probably best not to change to the new API unless SC removes the old methods completely.

@manonamora
Copy link
Contributor Author

Yeah... it would.
But because 2.37 deprecated Dialog.setup, it might be nice to have a version for 2.37 as well?

@greyelf
Copy link

greyelf commented Aug 11, 2024

Yeah... it would. But because 2.37 deprecated Dialog.setup, it might be nice to have a version for 2.37 as well?

I'm curious, what exactly would be gained by having an additional <<dialog>> equivalent macro that internally does this...

Dialog.create(title, classes.join(' '));

..instead of this...

Dialog.setup(title, classes.join(' '));

@ChapelR
Copy link
Owner

ChapelR commented Aug 12, 2024

It is future proofed. I guess I could have a separate branch for post-2.37, I'll think about whether I want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants