Set RPATH to $ORIGIN so shared objects can be found after installation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bare-bones commit that allows wheels to work on Linux. It needs some CMake fixes, e.g., gating the extra flag on CMAKE_SYSTEM_NAME being equal to Linux.
I believe there's another way to achieve the same thing, namely adding an
__init__.py(or similar) and using ctypes to preload the SOs, since they will be in a fixed location relative to that Python source file.While I think the auditwheel package might do something similar to (or better than!) this, it doesn't support ARM platforms, and we need pydnp3 on a Raspberry Pi-based system.