-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(query): change amazonaws.cn links to aws.amazon.com #7288
base: master
Are you sure you want to change the base?
Conversation
4d2c74f
to
2c271dd
Compare
2c271dd
to
90b5074
Compare
@ArturRibeiro-CX apologies for the direct ping, but I'm wondering if/how this might be reviewed? I see a "requested a review from a team" item in the PR history, but it doesn't seem like it correctly tagged anyone. |
Hi @connorg, no problem at all for the ping! The "requested a review from KICS" action is sufficient to notify the team about your PR. From there, the KICS team can review it, approve, and run the necessary test pipeline to ensure alignment with the codebase and existing tests. If everything checks out, they can proceed with approval on their side. I'm sure the team will take a look at it as soon as they can. Thanks for your contribution! |
90b5074
to
32a662f
Compare
4220ca5
to
292d26a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @connorg,
Sorry for the delay in getting back to you!
I've run the test pipelines, and everything looks good. I also reviewed the proposed changes and left a few quality-of-life comments, please take a look and let me know if you agree with the suggestions.
Additionally, the failing security check GitHub Actions will be resolved once #7350 is merged. To address this, I’ll merge master into your branch to fix the vulnerabilities, and after that, your PR should be good to go!
Thanks for your contribution, and apologies again for any inconvenience!
assets/queries/cloudFormation/aws/access_key_not_rotated_within_90_days/metadata.json
Outdated
Show resolved
Hide resolved
assets/queries/cloudFormation/aws/iam_access_analyzer_not_enabled/metadata.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We’ll merge your PR as soon as possible.
Congratulations on your first contribution, and thanks for your commitment! 🎉
Closes: no issue filed, but I can file one if required
Reason for Proposed Changes
.cn
.Proposed Changes
docs.amazonaws.cn
todocs.aws.amazon.com
I submit this contribution under the Apache-2.0 license.