Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queries): fix var shadows builtin regal lint issue #7346

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Feb 24, 2025

Fix var-shadows-builtin regal lint issue

This PR renames variables in Rego files that previously shadowed Rego's built-in functions. By addressing these conflicts, we ensure that variable names do not unintentionally override or interfere with built-in functionality, improving code reliability and maintainability.

Reason for Proposed Changes

  • Prevent conflicts between variable names and Rego built-ins to avoid unexpected behavior.
  • Ensure compliance with Regal Linter’s var-shadows-builtin checks.
  • Improve clarity by renaming variables while maintaining their intended functionality.

Proposed Changes

  • Rename variables such as array and elem in inArray() to avoid shadowing Rego's built-ins.
  • Apply consistent naming conventions across all affected queries.
  • Ensure all affected files pass Regal Linter without var-shadows-builtin warnings.

Continuation of #7295

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX added feature request Community: new feature request feature New feature query New query feature community Community contribution labels Feb 24, 2025
@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Feb 24, 2025
Copy link
Contributor

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review February 24, 2025 23:45
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner February 24, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant