Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queries): fix defer assignment regal lint issue #7366

Open
wants to merge 95 commits into
base: master
Choose a base branch
from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Mar 2, 2025

Fix defer assignment regal lint issue

This PR addresses the Regal lint warnings related to defer-assignment by deferring variable assignments until they are needed. Instead of assigning values upfront, the logic has been updated to perform assignments only when necessary, improving performance and readability. This approach aligns with best practices and ensures consistency across Rego policies.

Reason for Proposed Changes

  • Optimize rule performance by deferring assignments until required;
  • Ensure compliance with Regal Linter’s defer-assignment rule;
  • Improve readability and maintainability by streamlining variable usage.

Proposed Changes

  • Refactored variable assignments to only occur when needed;
  • Eliminated unnecessary intermediate assignments while maintaining rule logic;
  • Ensured all affected files pass Regal Linter without defer-assignment warnings.

Continuation of #7295

I submit this contribution under the Apache-2.0 license.

ArturRibeiro-CX and others added 30 commits February 23, 2025 12:48
@ArturRibeiro-CX ArturRibeiro-CX added feature New feature query New query feature community Community contribution labels Mar 2, 2025
@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Mar 2, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review March 2, 2025 23:15
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner March 2, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant