Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(queries): fix defer redundant alias regal lint issue #7367

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

feat(queries): fix defer redundant alias regal lint issue #7367

wants to merge 97 commits into from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Mar 2, 2025 •
edited
Loading

Fix redundant alias regal lint issue

This PR fixes a Regal lint warning related to redundant alias usage by removing an unnecessary alias. This improves code clarity and aligns with best practices for Rego policies.

Reason for Proposed Changes

  • Ensure compliance with Regal Linter’s redundant-alias rule;
  • Improve readability by eliminating unnecessary aliasing.

Proposed Changes

  • Removed a redundant alias to streamline rule logic;
  • Ensured the affected file passes Regal Linter without redundant-alias warnings.

Continuation of #7295

I submit this contribution under the Apache-2.0 license.

ArturRibeiro-CX and others added 30 commits February 23, 2025 12:48
@ArturRibeiro-CX
add initial regal lint setup
4477f67
@ArturRibeiro-CX
test regal linter
3cd6fc2
@ArturRibeiro-CX
revert rego changes
bb6bc2f
@ArturRibeiro-CX
opa fmt lint fixes on all rego files
b012c13
@ArturRibeiro-CX
ignore all linter rules besides opa-fmt
336243f
@ArturRibeiro-CX
add new lint rules to ignore
70b2757
@ArturRibeiro-CX
reorganize lint rules into the right rule
7223ef4
@ArturRibeiro-CX
add more rules to the config file
24470f0
@ArturRibeiro-CX
add more rules and fix opa-fmt problem
505e5c4
@ArturRibeiro-CX
test to check lint rule-shadows-builtin issues
3da838e
@ArturRibeiro-CX
fix rule shadows builtin lint issue in .rego queries
4a7a327
@ArturRibeiro-CX
fix lint
2f8f66d
@ArturRibeiro-CX
update level on var-shadows-builtin to tackle lint issues
a1c5db6
@ArturRibeiro-CX
fix var-shadows-builtin lint issues
853b31f
@ArturRibeiro-CX
fix var-shadows-builtin lint issues
5e4cbf8
@ArturRibeiro-CX
Merge branch 'master' into regal-var-shadows-builtin
f6b7aa8
@ArturRibeiro-CX
Merge branch 'regal-var-shadows-builtin' of https://github.com/Checkm…
d0bfc17 
…arx/kics into regal-var-shadows-builtin
@ArturRibeiro-CX
fix var-shadows-builtin lint issues
0954762
@ArturRibeiro-CX
first commit to trigger regal linter non-raw-regex-pattern
383e6c5
@ArturRibeiro-CX
fix non-raw-regex-pattern lint issues
f8740d1
@ArturRibeiro-CX
fix non-raw-regex-pattern lint issues
14bc51e
@ArturRibeiro-CX
initial commit to trigger regal linter no-whitespace-comment rule
b70dd5b
@ArturRibeiro-CX
Merge branch 'master' into regal-no-whitespace-comment
03a7880
@ArturRibeiro-CX
initial fix to regal linter no-whitespace-comment rule
84eb2e8
@ArturRibeiro-CX
fix to regal linter no-whitespace-comment rule
1a12a27
@ArturRibeiro-CX
fix to regal linter no-whitespace-comment rule
d872fb5
@ArturRibeiro-CX
fix to regal linter no-whitespace-comment rule
5837e53
@ArturRibeiro-CX
fix to regal linter no-whitespace-comment rule
543fd8e
@ArturRibeiro-CX
initial commit to trigger to regal linter use-in-operator rule
d18bcdb
@ArturRibeiro-CX
Fix regal linter use-in-operator rule
a0e06ca
@ArturRibeiro-CX
test fix defer assigment k8s pod or container query
432bb6b
@ArturRibeiro-CX
test fix defer assigment
94b1d46
@ArturRibeiro-CX
fix typo
c69c2e9
@ArturRibeiro-CX
fix defer assignment regal lint issue
544cefe
@ArturRibeiro-CX
fix defer assignment regal lint issue cloudformation
4d21bf1
@ArturRibeiro-CX
fix defer assignment regal lint issue cloudformation
ad01db6
@ArturRibeiro-CX
fix defer assignment regal lint issue cloudformation app_access query
7d2dce4
@ArturRibeiro-CX
try fix test
f7fef2a
@ArturRibeiro-CX
try fix regal linter defer assignment test
e72919c
@ArturRibeiro-CX
try fix regal linter defer assignment test
3c57fde
@ArturRibeiro-CX
fix regal lint issue
853fe81
@ArturRibeiro-CX
fix regal lint defer-assignment issue
3a55edd
@ArturRibeiro-CX
try to fix regal lint defer-assignment issue
ed6007b
@ArturRibeiro-CX
try to fix regal lint defer-assignment issue
c2f0dec
@ArturRibeiro-CX
fix regal lint defer-assignment issue
3403309
@ArturRibeiro-CX
fix regal lint defer-assignment issues
4346e70
@ArturRibeiro-CX
fix regal lint defer-assignment issues
aeadfd7
@ArturRibeiro-CX
fix regal lint defer-assignment issues
413ddf2
@ArturRibeiro-CX
fix tests
b828991
@ArturRibeiro-CX
initial commit to trigger redundant-alias regal lint issues
7be0d81
@ArturRibeiro-CX ArturRibeiro-CX added feature request Community: new feature request feature New feature query New query feature community Community contribution labels Mar 2, 2025
@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Mar 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review March 2, 2025 23:47
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner March 2, 2025 23:47
@ArturRibeiro-CX ArturRibeiro-CX changed the title feat(queries): fix defer redundant alias lint issue feat(queries): fix defer redundant alias regal lint issue Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ArturRibeiro-CX ArturRibeiro-CX

Labels
community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArturRibeiro-CX