Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert ssl verify query #791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

invert ssl verify query #791

wants to merge 1 commit into from

Conversation

lagrip
Copy link

@lagrip lagrip commented Feb 17, 2025

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

SMS Api with "Ignore to check SSL" fails because the query code is wrong.

Bug reports

Please include:

  • Your operating system name and version
    • Ubuntu 24.04
  • Detailed steps to reproduce the bug
    • Configure Notification via SMS Api. Use https.
    • Tick "Disable SSL certificate verification"
    • Trigger a notification

Proposed changes

Sometimes it is hard for us to assess the quality of a fix.
While it may work for you, it is our job to ensure that it works for everybody.
These are some ways to help us:

  • What is the expected behavior?
    • Get the SMS notification
  • What is the observed behavior?
    • Error complaining about the ssl certificate
  • Workaround: Do not tick "Disable SSL certificate verification" and use https anyway
  • If it's not obvious from the above: In what way does your patch change the current behavior?
    • To ignore ssl verification - as the checkbox is meant to do
  • Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?
    • Migrating vom smstools to SMS Api

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.


SCS-NT\lgrippi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@lagrip
Copy link
Author

lagrip commented Feb 17, 2025

I have read the CLA Document and I hereby sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant