mssql_jobs without a name #796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Some mssql_jobs may not have a name.
It occurred that some jobs do not have a name so that field is missing in the agent plugin output (both, the deprecated mssql.vbs and the new mk-sql.exe) and will be set to an empty string in the parsed output.
That leads to a discovery crash and all subsequent jobs will not be discovered as well, so I added the proof of the length of the job_name to keep the discovery from crashing.
Example agent plugin output of mk-sql.exe is attached.
mssql_jobs.txt