Add puzzles, driver and lifecycle tests for revocable CATs #19000
Conversation
Details can be found in the accompanying CHIP
| @@ -0,0 +1,64 @@ | |||
| ; This layer ensures that a second puzzle hash or "backdoor" that can be used without the inner puzzle's permission | |||
There was a problem hiding this comment.
Why are you duplicating this puzzle rather than importing the existing one?
There was a problem hiding this comment.
Various people didn't want to use the previous name.
So I've added it with a different name, since I didn't want to change the VC code.
| def construct_p2_delegated_by_singleton(issuer_launcher_id: bytes32) -> Program: | ||
| singleton_struct: Program = Program.to( | ||
| ( | ||
| SINGLETON_TOP_LAYER_MOD_HASH, |
There was a problem hiding this comment.
It's important in these drivers to have optional ways to override these values. Sometimes, in tests, I like to use a "mock" singleton puzzle, and these drivers wouldn't work for that.
There was a problem hiding this comment.
Same goes for similar functions below.
There was a problem hiding this comment.
That's a good idea, although as you said, I don't think that driver will be merged into chia-blockchain anytime soon.
Would add that in case we do want to use it here.
|
|
||
|
|
||
| @pytest.mark.anyio | ||
| async def test_revocable_cat_lifecycle(cost_logger): |
There was a problem hiding this comment.
I realize this is copied from a real in-"production" test but it's from like 3 years ago. Using the standard puzzle as the p2 puzzle really over complicates the whole file and makes it difficult to review and get accurate cost metrics. I would rather use Program.to(1) as the inner puzzle where possible because it's the minimal-est puzzle that allows for what you need and therefore weighs on the cost number the least.
There was a problem hiding this comment.
That makes sense, will use that!
I've seen that with other tests, but my first thought was that using the "real" puzzle brings the tests closer to reality.
But that doesn't really matter, I imagine.
|
|
||
| @pytest.mark.anyio | ||
| async def test_revocable_cat_lifecycle(cost_logger): | ||
| async with sim_and_client() as (sim, sim_client): |
There was a problem hiding this comment.
I left comments on the other file that should apparently be deleted about simplifying this test function.
There was a problem hiding this comment.
Yes, that other file was a duplicate I've committed by mistake
|
Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits. |
greimela
force-pushed
the
revocable-cats
branch
from
1b38f2f to
b29d87f
Compare
emlowe
added
the
Added
Details can be found in the accompanying CHIP.